add support for stateful handler #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
force-pushed
the
feature/stateful-handlers
branch
3 times, most recently
from
3c59e86 to
f389916
Compare
|
one year later, but this addresses #11 if I understand the need correctly |
yim-lee
reviewed
Mar 11, 2021
weissi
reviewed
Mar 11, 2021
tomerd
force-pushed
the
feature/stateful-handlers
branch
from
6baa856 to
164106e
Compare
yim-lee
approved these changes
Mar 12, 2021
tomerd
force-pushed
the
feature/stateful-handlers
branch
from
b833f28 to
5e4546c
Compare
motivation: allow lifecycle handlers to have the library manage the state for them so they do not need to do that manually changes: * introduce LifecycleStartHandler and LifecycleShutdownHandler which can handle state on behalf of the lifecycle item * add registerStateful function to regsiter stateful handlers * add tests
tomerd
force-pushed
the
feature/stateful-handlers
branch
from
5e4546c to
397eade
Compare
|
@swift-server-bot test this please |
yim-lee
approved these changes
Mar 12, 2021
ktoso
reviewed
Mar 13, 2021
| For example, when establishing some sort of a connection that needs to be closed at shutdown. | ||
|
|
||
| ```swift | ||
| struct Foo { |
There was a problem hiding this comment.
Or if it conforms to LifecycleStartHandler one could just pass it as?
There was a problem hiding this comment.
Ah i see... you only surface the new APIs really, not forcing people to impl anything. That sounds good 👍
ktoso
approved these changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: allow lifecycle handlers to have the library manage the state for them so they do not need to do that manually
changes: