Add API to get the language in which a symbol is defined and the symbol provider for a source file #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
akyrtzi,
benlangmuir and
bnbarham
as code owners
ahoppen
force-pushed
the
ahoppen/get-source-language
branch
from
b6a4594 to
9e1db56
Compare
ahoppen
force-pushed
the
ahoppen/get-source-language
branch
from
9e1db56 to
a335a47
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Feb 2, 2024
Comment on lines
+35
to
+36
| llvm::sys::TimePoint<> modTime, Optional | ||
| <SymbolProviderKind> SymProviderKind) |
There was a problem hiding this comment.
Did clang-format do that? Please tell me it didn't 😅
There was a problem hiding this comment.
No, that was me messing up the formatting
| return true | ||
| } | ||
|
|
||
| if result == nil { |
There was a problem hiding this comment.
Is this worth it? Would be a pretty weird state to be in, may as well just return the first.
There was a problem hiding this comment.
I don’t have strong opinions either way. indexstoredb_index_units_containing_file also shouldn’t return many files so not sure if exiting early really makes a difference.
ahoppen
added a commit
to ahoppen/indexstore-db
that referenced
this pull request
Feb 2, 2024
ahoppen
added a commit
that referenced
this pull request
Feb 3, 2024
Fix a formatting issue from #177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used by sourcekit-lsp’s cross-file rename.