Reduce memory consumption for OutOfDateTriggerHints #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
akyrtzi,
benlangmuir and
bnbarham
as code owners
benlangmuir
reviewed
Feb 21, 2024
bnbarham
approved these changes
Feb 21, 2024
Remove `DependentUnitOutOfDateTriggerHint`, and collapse the class hierarchy into a single class `OutOfDateFileTrigger`, which stores both the file name as well as the mod time. Then, change the `OutOfDateTriggers` map in UnitMonitor to use StringRef keys. This significantly reduces memory consumption for large projects. We could likely go further here by eliminating the storing of triggers completely, but I'm leaving that as future work for now. rdar://50929788
hamishknight
force-pushed
the
take-a-hint
branch
from
56b3f4c to
9afa14e
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
DependentUnitOutOfDateTriggerHint, and collapse the class hierarchy into a single classOutOfDateFileTrigger, which stores both the file name as well as the mod time. Then, change theOutOfDateTriggersmap in UnitMonitor to use StringRef keys. This significantly reduces memory consumption for large projects. We could likely go further here by eliminating the storing of triggers completely, but I'm leaving that as future work for now.rdar://50929788