Skip to content

Mark SymbolProperty and SymbolRole as Sendable #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2024
Merged

Mark SymbolProperty and SymbolRole as Sendable #196

merged 1 commit into from
May 13, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 13, 2024

  • Explanation: This allows us to build the SourceKitLSP module in Swift 6 mode.
  • Scope: Adding Sendable annotations
  • Risk: Very low, just adds Sendable annotations
  • Testing: Verified that this helps build SourceKit-LSP in Swift 6 mode
  • Issue: n/a
  • Reviewer: @bnbarham on Mark SymbolProperty and SymbolRole as Sendable #195

@ahoppen
Mark SymbolProperty and SymbolRole as Sendable
0664006 
This allows us to build the `SourceKitLSP` module in Swift 6 mode.
@ahoppen
Copy link
Member Author

ahoppen commented May 13, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit 4122238 into swiftlang:release/6.0 May 13, 2024
3 checks passed
@ahoppen ahoppen deleted the 6.0/some-sendable-annotations branch May 13, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@akyrtzi akyrtzi Awaiting requested review from akyrtzi

@benlangmuir benlangmuir Awaiting requested review from benlangmuir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @bnbarham