Disable UBSAN on macOS #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building indexstore-db with ubsan enabled with an Xcode 15.1 SDK causes C++ exception to not be catchable with `try {} catch {}` blocks and indexstore-db relies on exception catching, possibly related to https://stackoverflow.com/questions/51673343/clang-with-libc-exceptions.
Disable UBSAN for now and re-enable it when CI nodes has been updated to Xcode 16.
|
@swift-ci Please test |
bnbarham
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building indexstore-db with ubsan enabled with an Xcode 15.1 SDK causes C++ exception to not be catchable with
try {} catch {}blocks and indexstore-db relies on exception catching, possibly related to https://stackoverflow.com/questions/51673343/clang-with-libc-exceptions.Disable UBSAN for now and re-enable it when CI nodes has been updated to Xcode 16.