Fix the managing of the session dictionary when you have nested wrappers #10345
Conversation
|
@swift-ci please test |
|
The two failing checks lead nowhere. Let's try this again. |
|
@swift-ci please test macOS Windows |
|
@swift-ci please test |
|
One test failure is that the SBThread.stop_info_data was not found. I'll try regenerating the python bindings to see if that fixes that one. The other is a swift test failure that doesn't look related. |
jimingham
force-pushed
the
swiftlang-python-callbacks
branch
from
bb1370a to
91be248
Compare
|
I had made the original cherry-pick against stable/20240723 at a point when there was an unrelated failing test still in the branch. That was why I was getting the stop_reason_data not found issue. Rebasing the patch to a newer source base should fix that failure. |
|
@swift-ci please test |
…ers (llvm#132846) Since the inner wrapper call might have removed one of the entries from the global dict that the outer wrapper ALSO was going to delete, make sure that we check that the key is still in the global dict before trying to act on it. (cherry picked from commit 8704635)
jimingham
force-pushed
the
swiftlang-python-callbacks
branch
from
91be248 to
cfd30cb
Compare
|
I rebased the patch again. The last time it was again something not relevant to this patch that was failing. Let's see if I have better luck this time. |
|
@swift-ci please test |
|
This is against 20230723 which is no longer a thing. Closing this to apply to release/6.2 instead. |
From (llvm#132846)
Since the inner wrapper call might have removed one of the entries from the global dict that the outer wrapper ALSO was going to delete, make sure that we check that the key is still in the global dict before trying to act on it.
(cherry picked from commit 8704635)