forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 339
[lldb] Script determinism of TestSwiftActorUnprioritisedJobs #10435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kastiglione
wants to merge
6
commits into
stable/20240723
Choose a base branch
from
dl/lldb-Script-determinism-of-TestSwiftActorUnprioritisedJobs
base: stable/20240723
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−11
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0335696
[lldb] Make TestSwiftActorUnprioritisedJobs deterministic
kastiglione 88ecc14
Run and show `bt all`
kastiglione 1bb5bc7
Attempt forward progress of other threads
kastiglione e8537a7
Add missing thread.Suspend()
kastiglione f7f225f
Unconditionally run other threads
kastiglione 56e5307
Increase sleep wait
kastiglione File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
40 changes: 32 additions & 8 deletions
40
lldb/test/API/lang/swift/async/actors/unprioritised_jobs/TestSwiftActorUnprioritisedJobs.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,54 @@ | ||
import time | ||
from contextlib import contextmanager | ||
import lldb | ||
from lldbsuite.test.decorators import * | ||
from lldbsuite.test.lldbtest import * | ||
from lldbsuite.test import lldbutil | ||
|
||
|
||
@contextmanager | ||
def _managed_async(dbg): | ||
async_state = dbg.GetAsync() | ||
try: | ||
yield | ||
finally: | ||
dbg.SetAsync(async_state) | ||
|
||
|
||
class TestCase(TestBase): | ||
|
||
@swiftTest | ||
@skipUnlessFoundation | ||
@skipIfWindows # temporarily skip test until fails can be investigated | ||
@skipIfLinux # temporarily skip test until fails can be investigated | ||
@skipIfDarwin # temporarily skip test until fails can be investigated | ||
def test_actor_unprioritised_jobs(self): | ||
"""Verify that an actor exposes its unprioritised jobs (queue).""" | ||
self.build() | ||
_, _, thread, _ = lldbutil.run_to_source_breakpoint( | ||
_, process, thread, _ = lldbutil.run_to_source_breakpoint( | ||
self, "break here", lldb.SBFileSpec("main.swift") | ||
) | ||
frame = thread.GetSelectedFrame() | ||
|
||
with _managed_async(self.dbg): | ||
# Suspend the current thread. | ||
thread.Suspend() | ||
# Continue - other threads only. | ||
self.dbg.SetAsync(True) | ||
process.Continue() | ||
# Wait - allowing other threads to run. | ||
time.sleep(5) | ||
# Stop the threads. | ||
self.dbg.SetAsync(False) | ||
self.dbg.HandleCommand("process interrupt") | ||
# Note: After a single interrupt, lldb reports the process as | ||
# running, but two interrupt calls results in a stopped process. | ||
# Also, using `process.Stop()` instead of `"process interrupt"` | ||
# did not work. | ||
self.dbg.HandleCommand("process interrupt") | ||
|
||
defaultActor = frame.var("a.$defaultActor") | ||
self.assertEqual(defaultActor.summary, "running") | ||
unprioritised_jobs = defaultActor.GetChildMemberWithName("unprioritised_jobs") | ||
# There are 4 child tasks (async let), the first one occupies the actor | ||
# with a sleep, the next 3 go on to the queue. | ||
# TODO: rdar://148377173 | ||
# self.assertEqual(unprioritised_jobs.num_children, 3) | ||
self.assertEqual(unprioritised_jobs.num_children, 3) | ||
self.assertEqual(defaultActor.summary, "running") | ||
for job in unprioritised_jobs: | ||
self.assertRegex(job.name, r"^\d+") | ||
self.assertRegex(job.summary, r"^id:\d+ flags:\S+") |
4 changes: 1 addition & 3 deletions
4
lldb/test/API/lang/swift/async/actors/unprioritised_jobs/main.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually do something like this (copied from another test)
to guard against even slower as an bots.