Skip to content

[lldb] Script determinism of TestSwiftActorUnprioritisedJobs #10435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: stable/20240723
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,30 +1,54 @@
import time
from contextlib import contextmanager
import lldb
from lldbsuite.test.decorators import *
from lldbsuite.test.lldbtest import *
from lldbsuite.test import lldbutil


@contextmanager
def _managed_async(dbg):
async_state = dbg.GetAsync()
try:
yield
finally:
dbg.SetAsync(async_state)


class TestCase(TestBase):

@swiftTest
@skipUnlessFoundation
@skipIfWindows # temporarily skip test until fails can be investigated
@skipIfLinux # temporarily skip test until fails can be investigated
@skipIfDarwin # temporarily skip test until fails can be investigated
def test_actor_unprioritised_jobs(self):
"""Verify that an actor exposes its unprioritised jobs (queue)."""
self.build()
_, _, thread, _ = lldbutil.run_to_source_breakpoint(
_, process, thread, _ = lldbutil.run_to_source_breakpoint(
self, "break here", lldb.SBFileSpec("main.swift")
)
frame = thread.GetSelectedFrame()

with _managed_async(self.dbg):
# Suspend the current thread.
thread.Suspend()
# Continue - other threads only.
self.dbg.SetAsync(True)
process.Continue()
# Wait - allowing other threads to run.
time.sleep(5)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually do something like this (copied from another test)

DEFAULT_TIMEOUT = 20 * (10 if ("ASAN_OPTIONS" in os.environ) else 1)

to guard against even slower as an bots.

# Stop the threads.
self.dbg.SetAsync(False)
self.dbg.HandleCommand("process interrupt")
# Note: After a single interrupt, lldb reports the process as
# running, but two interrupt calls results in a stopped process.
# Also, using `process.Stop()` instead of `"process interrupt"`
# did not work.
self.dbg.HandleCommand("process interrupt")

defaultActor = frame.var("a.$defaultActor")
self.assertEqual(defaultActor.summary, "running")
unprioritised_jobs = defaultActor.GetChildMemberWithName("unprioritised_jobs")
# There are 4 child tasks (async let), the first one occupies the actor
# with a sleep, the next 3 go on to the queue.
# TODO: rdar://148377173
# self.assertEqual(unprioritised_jobs.num_children, 3)
self.assertEqual(unprioritised_jobs.num_children, 3)
self.assertEqual(defaultActor.summary, "running")
for job in unprioritised_jobs:
self.assertRegex(job.name, r"^\d+")
self.assertRegex(job.summary, r"^id:\d+ flags:\S+")
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import Foundation

actor Actor {
var data: Int = 15

func occupy() async {
Thread.sleep(forTimeInterval: 100)
_ = readLine()
}

func work() async -> Int {