[stable/20230725][lldb][cmake] Fix relative path used for lldb executables #7365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had this looking directly in `./swift/<os>/` before, but now that an installed lldb executable also links against Swift libraries, this needs to be the more general `../lib/swift/<os>/`.
bnbarham
approved these changes
Aug 30, 2023
|
@swift-ci please test |
|
Linux CI may be failing because it needs something like swiftlang/swift#68225 to be merged first? |
|
Yeah, feel free to just merge this. |
|
@swift-ci Please test |
|
Linux CI fails with unrelated compilation error, other CI failures should be unrelated since this pull only affects ELF runpaths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this looking directly in
./swift/<os>/before, but now that an installed lldb executable also links against Swift libraries, this needs to be the more general../lib/swift/<os>/.Pinging @rintaro and @bnbarham, cherry-pick of #7359.