Implement a syntactic test discovery fallback for XCTests written in Swift #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Swift If the index for a given file is not up-to-date, perform a syntactic scan for tests within it. This should allow editors to run the `textDocument/tests` request while the user is editing a file to scan it for test cases.
|
@swift-ci Please test |
bnbarham
approved these changes
Mar 30, 2024
| } | ||
| } catch { | ||
| logger.fault("Unable to determine if SymbolLocation is up-to-date: \(error.forLogging)") | ||
| return true |
There was a problem hiding this comment.
The only error at the moment is no mtime in attributes. Seems like we should just assume it isn't up to date in that case? I doubt it really matters though.
There was a problem hiding this comment.
My thinking was that if sourcekit-lsp is running on some platform that for some reason doesn’t have modification time or if Foundation doesn’t know how to extract it (not sure if those exist), it’s better to assume all files are up-to-date than to completely ignore index results. But as you said, I don’t think it really makes a difference.
There was a problem hiding this comment.
Fair enough, that's fine with me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the index for a given file is not up-to-date, perform a syntactic scan for tests within it.
This should allow editors to run the
textDocument/testsrequest while the user is editing a file to scan it for test cases.