Support member access in tags #1191
Conversation
There was a problem hiding this comment.
Nice. Thank you! One minor comment and the other question is whether we want to include the leading dot in the tag name. My initial thought would have been not to but I think this also highly depends on how it ends up being displayed in VS Code, so I’ll ultimately leave it up to you.
|
Talking with @grynspan we basically need to have the leading In VSCode we can just drop the leading |
|
Would VSCode present these tags with a leading |
plemarquand
force-pushed
the
tag-member-access-syntax
branch
from
69f13f4 to
ec5c614
Compare
Currently tags are only recognized when the tag is specified by string literal, i.e: @tag("foo"). Support Tags added via the staticMember Tag.Kind.
When a tag is declared within a nested type on Tag include the types name in the tags string representation.
Add a `components` property to MemberAccessExprSyntax that provides all the base names and the member's name as an array. When resolving swift-testing Tags check if they start with Tag or Testing.Tag and drop that from the name.
One that tests string tags, and the other that tests static tags.
To remove namespacing ambiguity, support statically defined tags only.
Add a `components` property to MemberAccessExprSyntax that provides all the base names and the member's name as an array. When resolving swift-testing Tags check if they start with Tag or Testing.Tag and drop that from the name.
One that tests string tags, and the other that tests static tags.
|
@grynspan VSCode automatically files tags under the top level test item so filtering by a tag called There are other automatic top level tags in VSCode such as |
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
|
Looks like there’s another formatting issue I usually run the formatter using the Run swift-format Run Task in VS Code. |
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Currently tags are only recognized when the tag is specified by string literal, i.e:
@Tag("foo").Support Tags added via the staticMember Tag.Kind, i.e:
@Tag(.blue).