Skip to content

Slightly simplify code completion logic #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Apr 19, 2024

Fallout from trying to fix rdar://126708088 (No closure expansion in call pattern completions) which I eventually gave up on because it required too much redesign of CodeCompletionSession for too little value for too much risk right now.

@ahoppen ahoppen requested a review from bnbarham April 19, 2024 22:13
@ahoppen ahoppen requested a review from benlangmuir as a code owner April 19, 2024 22:13
@ahoppen
Copy link
Member Author

ahoppen commented Apr 19, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit f73df6d into swiftlang:main Apr 23, 2024
3 checks passed
@ahoppen ahoppen deleted the completionsession-improvements branch April 23, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants