Skip to content

Show message if background indexing is enabled but the workspace doesn’t support background indexing #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 25, 2024

If the user has enabled background indexing in sourcekit-lsp but opens a project that doesn’t support background indexing (compilation database, build server), we should show a message after opening the workspace, informing the user that background indexing is only supported in SwiftPM projects at the moment.

Fixes #1255
rdar://127474711

@ahoppen ahoppen requested review from bnbarham and hamishknight May 25, 2024 21:28
@ahoppen ahoppen requested a review from benlangmuir as a code owner May 25, 2024 21:28
@ahoppen ahoppen force-pushed the show-background-indexing-not-supported-message branch from e6dcbd6 to 13d0bee Compare May 25, 2024 21:34
@ahoppen
Copy link
Member Author

ahoppen commented May 27, 2024

@swift-ci Please test

@ahoppen ahoppen force-pushed the show-background-indexing-not-supported-message branch from 13d0bee to d465ece Compare May 28, 2024 18:28
@ahoppen ahoppen changed the title Show message if background indexing is enabled but the workspace doesn’t support background indexing 🚥 #1350 Show message if background indexing is enabled but the workspace doesn’t support background indexing May 28, 2024
@ahoppen
Copy link
Member Author

ahoppen commented May 28, 2024

@swift-ci Please test

…n’t support background indexing

If the user has enabled background indexing in sourcekit-lsp but opens a project that doesn’t support background indexing (compilation database, build server), we should show a message after opening the workspace, informing the user that background indexing is only supported in SwiftPM projects at the moment.

Fixes swiftlang#1255
rdar://127474711
@ahoppen ahoppen force-pushed the show-background-indexing-not-supported-message branch from d465ece to e87d9e8 Compare May 28, 2024 21:14
@ahoppen
Copy link
Member Author

ahoppen commented May 28, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented May 28, 2024

@swift-ci Please test Windows

1 similar comment
@ahoppen
Copy link
Member Author

ahoppen commented May 29, 2024

@swift-ci Please test Windows

@ahoppen ahoppen merged commit c2bf81c into swiftlang:main May 29, 2024
3 checks passed
@ahoppen ahoppen deleted the show-background-indexing-not-supported-message branch May 29, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show message if background indexing is enabled but the workspace doesn’t support background indexing
3 participants