Allow specification of SourceKitLSPOptions in the initialize request and look for SourceKit-LSP options in $XDG_CONFIG_HOME/sourcekit-lsp
#1534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows editors to provide UI elements to toggle SourceKit-LSP options.
The reverse-DNS notation is macOS style and doesn’t feel at home on Linux.
|
@swift-ci Please test |
bnbarham
reviewed
Jun 28, 2024
| @@ -200,6 +200,21 @@ public struct SourceKitLSPOptions: Sendable, Codable { | |||
| self.workDoneProgressDebounce = workDoneProgressDebounce | |||
| } | |||
|
|
|||
| public init?(fromLSPAny lspAny: LSPAny?) throws { | |||
There was a problem hiding this comment.
Should we move this type to LSP so that clients can also construct it (though for that to actually be true we probably need to split LSP out of this repo, but still... seems like a reasonable place for it to live)?
There was a problem hiding this comment.
I started moving it to the LanguageServerProtocol module and then decided against it. I can’t really tell why but it didn’t feel at home there.
bnbarham
approved these changes
Jun 28, 2024
This was referenced Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying
SourceKitLSPOptionsin the initialize request allows editors to provide UI elements to toggle SourceKit-LSP options.The reverse-DNS notation is macOS style and doesn’t feel at home on Linux.