Make workspace/synchronize a non-experimental request
#2092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This request is generally useful, not only for tests within SourceKit-LSP but also: - In editor tests that want to test the integration with SourceKit-LSP - In code analysis tools that want to gather project information using SourceKit-LSP and need an up-to-date index for that. Remove the experimental feature guard from `workspace/_synchronize`, consequently rename it to `workspace/synchronize` and only guard the `buildServerUpdates` option on the synchronize request by an experimental feature because its long-term usefulness is still not fully understood yet.
ahoppen
added a commit
to ahoppen/swift-integration-tests
that referenced
this pull request
Mar 26, 2025
swiftlang/sourcekit-lsp#2092 changes the synchronize request to no longer be experimental.
This was referenced Mar 26, 2025
|
@swift-ci Please test |
hamishknight
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request is generally useful, not only for tests within SourceKit-LSP but also:
Remove the experimental feature guard from
workspace/_synchronize, consequently rename it toworkspace/synchronizeand only guard thebuildServerUpdatesoption on the synchronize request by an experimental feature because its long-term usefulness is still not fully understood yet.