[5.7] Close temporarily opened documents #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahoppen
commented
Jun 9, 2022
ahoppen
commented
- Explanation: To satisfy certain kinds of semantic requests, we open a source document with a temporary prefix but forgot to close them afterwards. This caused issues on Windows where these files are opened exclusively This fixes an issue for SourceKit-LSP on Windows where these files are opened exclusively and couldn’t be modified anymore.
- Scope: May affect pretty much all of SourceKit-LSP
- Risk: Low, not closing the documents was just an oversight
- Testing: @compnerd verified that the Windows issue no longer occurs with this fix
- Issue: Some sourcekitd documents opened in SwiftLanguageServer are never closed #553 (rdar://93154201)
- Reviewer: @benlangmuir on Close temporarily opened documents #566
We only open a document e.g. with the `FoldingRanges:` prefix to get the document structure as a one-off task, so we should be closing it afterwards. Fixes swiftlang#553 (rdar://93154201)
|
@swift-ci Please test |
benlangmuir
approved these changes
Jun 13, 2022
airspeedswift
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.