Skip to content

Fix use of deprecated AbsolutePath.init #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2023
Merged

Fix use of deprecated AbsolutePath.init #719

merged 1 commit into from
Mar 9, 2023

Conversation

MaxDesiatov
Copy link
Contributor

Non-throwing AbsolutePath.init(_:) is deprecated, we should use AbsolutePath.init(validating:) throws instead.

@MaxDesiatov MaxDesiatov self-assigned this Mar 9, 2023
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Mar 9, 2023 •
edited
Loading

Windows CI failure looks unrelated:

CMake Error: File C:/Users/swift-ci/jenkins/workspace/sourcekit-lsp-PR-windows/llvm-project/llvm/stdlib/public/Cxx/std/libstdcxx.modulemap does not exist.
CMake Error at C:/Users/swift-ci/jenkins/workspace/sourcekit-lsp-PR-windows/swift/unittests/ClangImporter/CMakeLists.txt:1 (configure_file):
  configure_file Problem configuring file


CMake Warning at C:/Users/swift-ci/jenkins/workspace/sourcekit-lsp-PR-windows/swift/unittests/runtime/CMakeLists.txt:19 (message):
  Building the swift runtime using the host compiler, and not the just-built
  clang.

@MaxDesiatov MaxDesiatov merged commit cf18660 into main Mar 9, 2023
@MaxDesiatov MaxDesiatov deleted the maxd/fix-absolutepath-warning branch March 9, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlangmuir benlangmuir benlangmuir approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

Assignees

@MaxDesiatov MaxDesiatov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @benlangmuir