Skip to content

Add support for looking up spec resources in a toolchain install #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

owenv
Copy link
Collaborator

@owenv owenv commented Mar 7, 2025

This will allow us to load resource bundles when installed as part of SwiftPM in a Swift toolchain

@owenv
Copy link
Collaborator Author

owenv commented Mar 7, 2025

@swift-ci test

@owenv owenv force-pushed the owenv/installed-spec-lookup branch from 1219096 to de18528 Compare March 7, 2025 21:29
@owenv
Copy link
Collaborator Author

owenv commented Mar 7, 2025

@swift-ci test

@owenv owenv force-pushed the owenv/installed-spec-lookup branch from de18528 to 9da332c Compare March 8, 2025 20:11
@owenv
Copy link
Collaborator Author

owenv commented Mar 8, 2025

@swift-ci test

@owenv owenv force-pushed the owenv/installed-spec-lookup branch from 9da332c to 0f6a64b Compare March 8, 2025 21:26
@owenv
Copy link
Collaborator Author

owenv commented Mar 8, 2025

@swift-ci test

Copy link
Collaborator

@jakepetroules jakepetroules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

@owenv owenv force-pushed the owenv/installed-spec-lookup branch from e73aefb to 0f6a64b Compare March 10, 2025 06:51
@owenv
Copy link
Collaborator Author

owenv commented Mar 10, 2025

@swift-ci test

@owenv owenv force-pushed the owenv/installed-spec-lookup branch from 0f6a64b to dedda2e Compare March 10, 2025 06:56
@owenv
Copy link
Collaborator Author

owenv commented Mar 10, 2025

@swift-ci test

@owenv
Copy link
Collaborator Author

owenv commented Mar 10, 2025

@swift-ci test Windows

@owenv owenv merged commit 2e6eb49 into main Mar 10, 2025
3 checks passed
@owenv owenv deleted the owenv/installed-spec-lookup branch March 10, 2025 17:03
plemarquand added a commit to plemarquand/swift-package-manager that referenced this pull request Mar 11, 2025
swiftlang/swift-build#266 changed the API of
SwiftBuildService.createSession.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants