Validate embedded frameworks #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon and
owenv
as code owners
|
@swift-ci please test |
|
neonichu
force-pushed
the
bbuegling/validate-embedded-frameworks
branch
from
5285c1a to
5a116e0
Compare
|
@swift-ci please test |
Sources/SWBTaskExecution/TaskActions/ValidateProductTaskAction.swift
Outdated
Show resolved
Hide resolved
jakepetroules
approved these changes
Mar 20, 2025
neonichu
force-pushed
the
bbuegling/validate-embedded-frameworks
branch
from
5a116e0 to
a2d26bf
Compare
Validate embedded frameworks as part of the `ValidateProductTaskAction` to surface issues which would later prevent installation or App Store submission. rdar://124355004
neonichu
force-pushed
the
bbuegling/validate-embedded-frameworks
branch
from
a2d26bf to
94e57b1
Compare
|
@swift-ci please test |
owenv
approved these changes
Mar 21, 2025
I think these failures are already known and definitely unrelated to this PR. |
|
@swift-ci please test macOS |
|
|
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate embedded frameworks as part of the
ValidateProductTaskActionto surface issues which would later prevent installation or App Store submission.rdar://124355004