Skip to content

Cater for new Swift reference count representation #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

johnno1962
Copy link
Contributor

Shouldn’t this fix for 32 bit systems be on the 4.2 branch? ARM Ports are coming up against this problem. uraimo/buildSwiftOnARM#15

@parkera
Copy link
Contributor

parkera commented Jul 11, 2018

For cherry picks to 4.2 it helps to have a reference to the master commit so we don't have to go searching for it.

@johnno1962
Copy link
Contributor Author

There you go: #1525

@parkera
Copy link
Contributor

parkera commented Jul 11, 2018

Cool, thanks!

@parkera
Copy link
Contributor

parkera commented Jul 11, 2018

@swift-ci test and merge

@johnno1962
Copy link
Contributor Author

What happened there?

@parkera
Copy link
Contributor

parkera commented Jul 12, 2018

Not sure. Let's try that again

@parkera
Copy link
Contributor

parkera commented Jul 12, 2018

@swift-ci test and merge

@swift-ci swift-ci merged commit 9ac09f5 into swiftlang:swift-4.2-branch Jul 12, 2018
@johnno1962
Copy link
Contributor Author

johnno1962 commented Jul 12, 2018

Thanks @parkera, good to see this merged. I can PR the other Android changes into 4.2 if you like i.e. #1518 but this was the most important.

@parkera
Copy link
Contributor

parkera commented Jul 12, 2018

If you have any others, now is a good time to propose them.

@johnno1962
Copy link
Contributor Author

OK, I’ve created #1631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants