Skip to content

Fix tests assuming that the temporary directory doesn't include symlinks #4723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2023
Merged

Fix tests assuming that the temporary directory doesn't include symlinks #4723

merged 1 commit into from
Mar 23, 2023

Conversation

tristanlabelle
Copy link
Contributor

Tests would break when the temporary directory included symlinks. This happens in the Windows build, which configures the temporary directory to be on a substituted drive.

compnerd
compnerd approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@compnerd
Copy link
Member

@swift-ci please test

@tristanlabelle
Copy link
Contributor Author

The test failures appear unrelated?

  Swift(macosx-x86_64) :: Concurrency/Runtime/custom_executors_moveOnly_job.swift
  Swift(macosx-x86_64) :: Concurrency/Runtime/custom_executors_priority.swift
  Swift(macosx-x86_64) :: Concurrency/Runtime/custom_executors_protocol.swift
  Swift(macosx-x86_64) :: Concurrency/Runtime/exclusivity_custom_executors.swift
  Swift(macosx-x86_64) :: Concurrency/custom_executor_enqueue_impls.swift
  Swift(macosx-x86_64) :: IRGen/async/builtin_executor.sil

@compnerd
Copy link
Member

@swift-ci please test macOS platform

@compnerd compnerd merged commit f7d28f0 into swiftlang:main Mar 23, 2023
@tristanlabelle tristanlabelle deleted the dont-assume-temp-dir-no-symlinks branch March 23, 2023 12:25
@tristanlabelle tristanlabelle mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tristanlabelle @compnerd