Windows long paths support #4750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
gwynne
reviewed
Jun 13, 2023
|
@swift-ci please test |
Refactor directory iteration to avoid replicating the conversion to the NT style paths everywhere. The iteration logic can be done at a single site with a callback to handle the iteration. Improve handle long file paths on Windows when performing a `removeItem` call. Furthermore, correct a few areas where we were mishandling junctions. This would result in an early termination of the loop in `removeItem` causing us to fail to clean up directories which we should have been able to. This improves the DocC test coverage on Windows. Rework the file attribute reading on Windows operation to reformulate the path to the absolute path representation and then into the NT form before performing the operation. This technically is a partial repair as drive relative paths where the current directory is deep enough, the path evaluation would fail. Co-authored-by: Gwynne Raskind <[email protected]>
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor directory iteration to avoid replicating the conversion to the
NT style paths everywhere. The iteration logic can be done at a single
site with a callback to handle the iteration.
Improve handle long file paths on Windows when performing a
removeItemcall. Furthermore, correct a few areas where we were mishandling
junctions. This would result in an early termination of the loop in
removeItemcausing us to fail to clean up directories which we shouldhave been able to. This improves the DocC test coverage on Windows.
Rework the file attribute reading on Windows operation to reformulate
the path to the absolute path representation and then into the NT form
before performing the operation. This technically is a partial repair
as drive relative paths where the current directory is deep enough, the
path evaluation would fail.