Fix divergent overwrite behavior of FileManager.copyItem(at:to:) on Linux and Windows #4821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parkera My apologies for the mistaken deletion of the original PR; can you re-review? |
compnerd
approved these changes
Sep 16, 2023
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Apple platforms, the
FileManagerAPIscopyItem(atPath:toPath:)andcopyItem(at:to:)refuse to overwrite the destination file (or link, or directory) if it already exists; this behavior is even explicitly documented. And indeed, any such attempt results in afileWriteFileExistserror.However, on Linux and Windows, the destination is silently overwritten. This PR changes that behavior to match what's documented. On POSIX platforms, this is accomplished by adding the
O_EXCLflag to the relevantopen(2)call, which results in anEEXISTerrno if the path already exists. For Windows, thebFailIfExistsparameter ofCopyFileW()is changed totrue.Fixes #3368
(This is a recreation of #4808, which was closed accidentally.)