Skip to content

[6.0] Adopt Swift 6 and audit for Sendable #5026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

parkera
Copy link
Contributor

@parkera parkera commented Jul 25, 2024

Cherry-pick of #5000 for release/6.0 branch.

* Adopt Sendable, fix Sendable related warnings, and fix other warnings in both Swift and C code

* Upgrade to Swift 6 - Fix associated warnings

* Remove Sendable annotation from NSAffineTransform

* Cleanup some unused types in Utilities and use a Mutex instead of NSLock

* Remove some warnings for Windows builds

* Add version 6 and warning flags to CMake file

* Adapt to some changes in how unchecked Sendable conformance is declared

* Update swift-foundation dependency

* Update locking strategy for DateFormatter and NumberFormatter - keep the CF type inside the lock

* Add annotations for Core and CFSocketRef

* Resolve a warning in TestDecimal

* Use noncopyable State type for DateFormatter and NumberFormatter

* Mark DirectoryEnumerator as non-Sendable

* Work around compiler crashes when using ~Copyable types

* Clarify comment of _nonSendable with a message explaining the remaining warning
@parkera
Copy link
Contributor Author

parkera commented Jul 25, 2024

@swift-ci test

@parkera
Copy link
Contributor Author

parkera commented Jul 25, 2024

@swift-ci test linux

@parkera parkera merged commit 204bdad into swiftlang:release/6.0 Jul 25, 2024
2 of 3 checks passed
@parkera parkera deleted the parkera/sendable_annotations_6 branch July 25, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant