-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Make completion-based send/receive functions public in URLSessionWebSocketTask
#5030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It would be a good idea to add a test case that calls into these (if we don't have one already). |
992a6c2
to
b6b8475
Compare
Test added. The test is the same as existing |
@swift-ci please test |
1 similar comment
@swift-ci please test |
Windows CI failed on checkout:
At least Linux is green. But I am not sure if it actually runs these tests. I don't see any output related to URLSession tests. |
LGTM thanks! Since web sockets are an experimental feature in curl, we'll need to run it with a curl where they're enabled to test it. I'll test it on a Fedora40 container to confirm |
Just a small note: these API is what is actually used by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's true, the tests are also all green for me on a container with web sockets enabled. Looks good and let's merge after Windows passes (I think that issue's been resolved). Thanks again!
@swift-ci please test Windows platform |
Completion-based send and receive are public in Apple Foundation.
Perhaps, availability should be added to the containing type, but I added it here for consistency with async counterparts.