Disable test_connectTimeout for flakiness on Linux #5046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
parkera
approved these changes
Aug 2, 2024
|
I guess the only option is to create dedicated server instance for this test. I'll try implementing that. |
|
Sounds good, thanks! I'm going to merge this for now while we look into that |
jrflat
added a commit
to jrflat/swift-corelibs-foundation
that referenced
this pull request
Aug 6, 2024
jrflat
added a commit
that referenced
this pull request
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestURLSession.test_connectTimeoutwas failing on Ubuntu 22.04 CI and I also reproduced the failure on Amazon Linux 2. It generally only fails when allTestURLSessioncases are run together, and I think it's related to stopping and starting the server during the test. Disable it for now while we figure out another way to test this specific connect timeout (a similar request timeout is still being tested by the test case above).