Skip to content

Add one more XCTAssert for isLeapMonth in TestDate.swift #5080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

lamtrinhdev
Copy link
Contributor

@lamtrinhdev lamtrinhdev commented Aug 29, 2024

isLeapMonth is a component in Date. Add one more XCTAssert for isLeapMonth in test_recreateDateComponentsFromDate.

@parkera
Copy link
Contributor

parkera commented Aug 29, 2024

We haven't traditionally always set this value (sometimes it is nil, depending on calendar). Is there something in particular we are trying to validate here?

@parkera
Copy link
Contributor

parkera commented Aug 29, 2024

@swift-ci test

@lamtrinhdev
Copy link
Contributor Author

We haven't traditionally always set this value (sometimes it is nil, depending on calendar). Is there something in particular we are trying to validate here?

Thank you for your review, @parkera . No particular, just see the test case that cover almost paramaters without it, and I would like to add it into test case.

@lamtrinhdev
Copy link
Contributor Author

Dear @parkera ,

It seems Swift Test macOS Platform has the problem. I have observed some previous merged PRs that have also failed with the Swift Test macOS Platform.

Thanks,
Lam

@parkera parkera merged commit ef225c7 into swiftlang:main Aug 30, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants