Skip to content

Change the signature for DispatchData.enumerateBytes() to match that … #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Change the signature for DispatchData.enumerateBytes() to match that … #386

merged 1 commit into from
Jul 18, 2018

Conversation

ktopley-apple
Copy link
Contributor

…of Data.enumerateBytes() for Swift 4.2 and obsolete the old version.

rdar://problem/40775762

…of Data.enumerateBytes() for Swift 4.2 and obsolete the old version.

rdar://problem/40775762
@ktopley-apple
Copy link
Contributor Author

@swift-ci please test

@ktopley-apple
Copy link
Contributor Author

This is a cherry-pick of the change in #385 on master back to the 4.2 branch.

@ktopley-apple
Copy link
Contributor Author

@swift-ci please nominate

Explanation: adds a new variant of DispatchData.enumerateBytes() for Swift 4.2 that matches the method in Data so that a single protocol can be used to manipulate objects of both types. The existing method is deprecated.
Scope: change to the API of DIspatchData
Radar/SR reference: rdar://problem/40775762, https://bugs.swift.org/browse/SR-7868.
Risk: Low. Code that uses the existing method will continue to work; on rebuild, Xcode should offer a fix-up for the obsolete method.
Testing: Tests have been added to verify that the correct version of the method is visible in Swift 4.2 and before, and to check that invocations that use trailing block syntax are unaffected.

@najacque najacque merged commit 25f3244 into swiftlang:swift-4.2-branch Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants