HAVE_MACH is unnecessary here. #549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kevent backend requires _dispatch_bug_kevent_client unconditionally. We don't need to require this entire function require HAVE_MACH, just the inner few lines that are already present behind this conditional.
|
In f03fa15 this was put in to possibly work around Ubuntu clang crashes -- let me know if this issue is still relevant. Perhaps changing it to the DISPATCH_EVENT_BACKEND_KEVENT conditional is better, which might necessitate further code movement and refactoring. |
|
ping. |
|
Closing in favor of #559. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kevent backend requires _dispatch_bug_kevent_client unconditionally.
We don't need to require this entire function require HAVE_MACH, just the
inner few that is already present behind this conditional.