Skip to content

Revert "[REVIEW] Add Async Support to XCTest" #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

compnerd
Copy link
Member

Reverts #326

This breaks swift-corelibs-foundation on Windows; given that the retrench is so close, I think that reverting it temporarily is safer unless someone can immediately spot what is going on.

CI logs: https://dev.azure.com/compnerd/3133d6ab-80a8-4996-ac4f-03df25cd3224/_apis/build/builds/54170/logs/148

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

CC: @briancroom - sadly this is somewhat urgent in light of the rebranch

@stmontgomery
Copy link
Contributor

@compnerd I'll go ahead and land this revert. I think we may need assistance debugging the Windows linker failure — it definitely looks related to this change, but it's not clear to me at first glance what may be going wrong.

(Side note: can you clarify what you mean by "in light of the rebranch"?)

@stmontgomery stmontgomery merged commit ad8f592 into main Sep 27, 2021
@compnerd compnerd deleted the revert-326-chefski/add-async-support branch September 27, 2021 16:02
@compnerd
Copy link
Member Author

compnerd commented Sep 27, 2021

@stmontgomery - the swift repositories are meant to update the LLVM base (rebranching) for updates today, and it would be nice to keep everything green across that large change.

I should be able to help with the debugging, I suspect that there is a silly bug in the compiler (with the async function pointer being referenced incorrectly across module boundaries).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants