Added the option to skip building the upstream while running the test… #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… script using an environment variable SWIFT_SKIP_BUILDING_UPSTREAM_DOCC
|
@swift-ci Please test |
bitjammer
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
The logic looks reasonable to me. @ethan-kusters do you concur with this approach?
ethan-kusters
approved these changes
Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… script using an environment variable SWIFT_SKIP_BUILDING_UPSTREAM_DOCC
Bug/issue #, if applicable:
Solves #22
Summary
Provides an option to skip cloning and building upstream docc and docc_render_artifact
Dependencies
None
Testing
Run the test with SWIFT_SKIP_BUILDING_UPSTREAM_DOCC set to true.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded