Preview: remove use of signal on Windows
#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows does not support signal(2). Instead, use `TerminateProcess` to terminate the process. We will not properly handle the termination of child processes for the preview process, which should be handled by the construction of a job object that all child processes are attached to such that when the parent process is terminated, the children will be properly reaped. This is required to enable building the plugin on Windows which is a dependency for swift-syntax.
|
@swift-ci please test |
|
CC: @DougGregor |
There was a problem hiding this comment.
This looks good to me, but i'll leave the final say to @ethan-kusters.
ethan-kusters
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Thanks @compnerd! Is this blocking SwiftSyntax? I can tag a new release with just the fix cherry-picked if so.
|
It's not blocking us, I'm going to temporarily remove this dependency from the main repository. Once we have a blue Windows build we can look into reintroducing it. |
|
Shall we merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows does not support signal(2). Instead, use
TerminateProcesstoterminate the process. We will not properly handle the termination of
child processes for the preview process, which should be handled by the
construction of a job object that all child processes are attached to
such that when the parent process is terminated, the children will be
properly reaped. This is required to enable building the plugin on
Windows which is a dependency for swift-syntax.