Copy snippet symbol graphs to the correct final destination #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @ethan-kusters for the patch! |
The snippet symbol graph is currently being generated with the changes in e013865, however they are not being copied to the correct final destination. The `snippet-extract` tool now takes input and output *files* instead of directories, however there is still one place in the plugin where we are still treating the output like a directory, so the snippet symbol graph basename path component looks like a directory, and needs additional basenames to put it in the right place with the correct file extension. rdar://104045850
bitjammer
force-pushed
the
acgarland/rdar-104045850-copy-snippet-symbol-graph-destination
branch
from
57cf8d9 to
427b250
Compare
|
@swift-ci Please test |
ethan-kusters
approved these changes
Jan 10, 2023
…-graph-destination
|
@swift-ci please test |
bitjammer
deleted the
acgarland/rdar-104045850-copy-snippet-symbol-graph-destination
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snippet symbol graph is currently being generated with the changes in e013865, however they are not being copied to the correct final destination.
The
snippet-extracttool now takes input and output files instead of directories, however there is still one place in the plugin where we are still treating the output like a directory, so the snippet symbol graph basename path component looks like a directory, and needs additional basenames to put it in the right place with the correct file extension.rdar://104045850
./bin/testscript and it succeeded