Ensure highlight.js builds only the files that are imported #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x wonky node_modules reference
mportiz08
approved these changes
Aug 1, 2023
| @@ -90,7 +90,7 @@ async function importHighlightFileForLanguage(language) { | |||
| languageFile = await import( | |||
| // See bug https://github.com/webpack/webpack/issues/13865 | |||
| /* webpackChunkName: "highlight-js-[request]" */ | |||
| `@/../node_modules/highlight.js/lib/languages/${file}` | |||
| `highlight-js-alias/lib/languages/${file}` | |||
There was a problem hiding this comment.
Should we be using the new alias in all places where we import files from this package or is this the only import that needed to be explicitly changed to use the alias? Just curious.
I'm guessing just this one since it's the only one using the @.
There was a problem hiding this comment.
Nah. the alias is just for here, because there is a webpack bug that we cannot dynamically import those lang files, so it needs an absolute path.
|
@swift-ci test |
mportiz08
added a commit
to mportiz08/swift-docc-render
that referenced
this pull request
Sep 12, 2023
This is a regression mistakenly introduced with [swiftlang#724][0] that prevents non-custom syntax languages (everything except swift/markdown) from being highlighted as expected due to an `import` call that is throwing an exception. To fix it, we can simply append the `.js` file extension to ensure that the import continues to work as expected. [0]: swiftlang#724
3 tasks
mportiz08
added a commit
that referenced
this pull request
Sep 13, 2023
This is a regression mistakenly introduced with [#724][0] that prevents non-custom syntax languages (everything except swift/markdown) from being highlighted as expected due to an `import` call that is throwing an exception. To fix it, we can simply append the `.js` file extension to ensure that the import continues to work as expected. Resolves: rdar://115169709 [0]: #724
mportiz08
added a commit
to mportiz08/swift-docc-render
that referenced
this pull request
Oct 17, 2023
This is a regression mistakenly introduced with [swiftlang#724][0] that prevents non-custom syntax languages (everything except swift/markdown) from being highlighted as expected due to an `import` call that is throwing an exception. To fix it, we can simply append the `.js` file extension to ensure that the import continues to work as expected. Resolves: rdar://115169709 [0]: swiftlang#724
mportiz08
added a commit
that referenced
this pull request
Oct 17, 2023
This is a regression mistakenly introduced with [#724][0] that prevents non-custom syntax languages (everything except swift/markdown) from being highlighted as expected due to an `import` call that is throwing an exception. To fix it, we can simply append the `.js` file extension to ensure that the import continues to work as expected. Resolves: rdar://115169709 [0]: #724
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 113252221
Summary
Fixes and issue with webpack pulling in more highlight.js files than it should + fixes the node modules path
Dependencies
NA
Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded