Transform item's path to lowercase in navigator #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mportiz08
reviewed
May 24, 2024
| @@ -89,7 +89,7 @@ | |||
| :is="refComponent" | |||
| :id="item.uid" | |||
| :class="{ bolded: isBold }" | |||
| :url="isGroupMarker ? null : (item.path || '')" | |||
| :url="isGroupMarker ? null : (item.path.toLowerCase() || '')" | |||
There was a problem hiding this comment.
Instead of changing the URL itself, maybe we can just add a new CSS class when item.path.toLowerCase() === this.$route.path.toLowerCase() that we apply the active/selected background color to?
That way we get the correct highlight/selection background color for the active item, regardless of whether the case matches between the two items, but we don't actually change the URL itself?
I think we investigated a similar problem with the tutorial dropdown in the past: #11
There was a problem hiding this comment.
Yes, it sounds like a better approach. I changed it.
It's a pity that vuejs/vue-router#3657 didn't get merged, it made sense to me.
marinaaisa
force-pushed
the
r122911237/item-path-lowercase
branch
from
82c3a22 to
fd27de3
Compare
|
@swift-ci test |
mportiz08
approved these changes
May 28, 2024
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #122911237, if applicable:
Summary
Transform item's path to lowercase in navigator, so if symbols have a path with capital letters, the highlighting of the active element in the navigator continues working
Dependencies
NA
Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded