Add row and column directives #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Articles currently don’t support having a directive as the first item of the discussion. This resolves the issue while maintaining compatibility with Metadata, Comment, and DeprecationSummary blocks.
ethan-kusters
force-pushed
the
row-and-column
branch
from
94729dd to
584b38b
Compare
|
@swift-ci please test |
ethan-kusters
force-pushed
the
row-and-column
branch
from
584b38b to
29531ae
Compare
|
@swift-ci please test |
Adds support for the @Row and @column directive as described here: https://forums.swift.org/t/supporting-more-dynamic-content-in-swift-docc-reference-documentation/59527#row-9. Resolves rdar://97739637
ethan-kusters
force-pushed
the
row-and-column
branch
from
29531ae to
52e9fed
Compare
|
@swift-ci please test |
franklinsch
approved these changes
Sep 13, 2022
| @@ -60,6 +60,8 @@ public enum RenderBlockContent: Equatable { | |||
| case termList(TermList) | |||
| /// A table that contains a list of row data. | |||
| case table(Table) | |||
|
|
|||
| case row(Row) | |||
There was a problem hiding this comment.
Looks like we're missing docs here, same for the public APIs below
There was a problem hiding this comment.
Thanks! Addressed here: d0c2e31.
|
@swift-ci please test |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://97739637
Summary
Adds support for
@Rowand@Columnin reference documentation pages.Described on the forums here: https://forums.swift.org/t/supporting-more-dynamic-content-in-swift-docc-reference-documentation/59527#row-9.
Dependencies
@Rowdirective swift-docc-render#409