Skip to content

[5.10] Use extensionTo and declaredIn relationships to add extensions to path hierarchy #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2023
Merged

[5.10] Use extensionTo and declaredIn relationships to add extensions to path hierarchy #727

merged 1 commit into from
Oct 9, 2023

Conversation

d-ronnqvist
Copy link
Contributor

Cherry-pick of #720

  • Explanation: Fix a crash in projects that have a public symbol that shadows the name of a module that the project extends.
  • Scope: Rare crash.
  • Issue: rdar://116469449
  • Risk: Low.
  • Testing: Added automated test with minimal reproducible example. Manually tested with projects from Update .spi.yml GetStream/stream-chat-swiftui#369 and rdar://109307328
  • Reviewer: @ethan-kusters

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist d-ronnqvist merged commit 5aecb97 into swiftlang:release/5.10 Oct 9, 2023
@d-ronnqvist d-ronnqvist deleted the shadow-extended-module-with-symbol-crash-5.10 branch October 9, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklinsch franklinsch franklinsch approved these changes

@Teapane Teapane Awaiting requested review from Teapane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-ronnqvist @franklinsch