Re-enable swiftinterface verification with compatibility headers #1203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lift the workaround that disabled scheduling the swiftinterface verification task when a compatibility header is generated. This is an issue only when the header is also installed, we now expect the build system to disable the verification when it installs the header. This issue lead to errors on missing headers and failures to build the underlying clang module at verification. rdar://100989723
|
@swift-ci Please test |
artemcm
approved these changes
Oct 12, 2022
tshortli
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lift the workaround that disabled scheduling the swiftinterface verification task when a compatibility header is generated. This is an issue only when the header is also installed, we now expect the build system to disable the verification when it installs the header.
For more context, this issue lead to errors on missing headers and failures to build the underlying clang module at verification.
rdar://100989723