-
Notifications
You must be signed in to change notification settings - Fork 199
Downgrade priors version mismatch warning #1396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade priors version mismatch warning #1396
Conversation
Could you please replace the warning with an incremental build remark, instead of removing it?
|
9e5f867
to
d6ad4a8
Compare
As a user when you're changing between versions of these files there's nothing you could do to avoid invalidation so this warning feel superfluous
@swift-ci please test |
d6ad4a8
to
855eddb
Compare
Updated to use that option instead! FWIW I do think that even a remark (if the user sees that) might be a bit more noise that desired (related thread: https://forums.swift.org/t/incremental-compilation-has-been-disabled-it-is-not-compatible-with-whole-module-optimization/66092). Maybe there should be a |
@swift-ci please test windows platform |
The remarks are really only meant for all of us to debug what's going on with incremental builds, so I think a bit of verbosity of this kind is just fine. Still though, very good to move it away from being an actual warning. |
Yea that makes sense, but I guess users do still end up seeing these, which might be confusing especially for ones that are this low level |
As a user when you're changing between versions of these files there's nothing you could do to avoid invalidation so this warning feel superfluous