Skip to content

Downgrade priors version mismatch warning #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

keith
Copy link
Member

@keith keith commented Jul 7, 2023

As a user when you're changing between versions of these files there's nothing you could do to avoid invalidation so this warning feel superfluous

@artemcm
Copy link
Contributor

artemcm commented Jul 18, 2023

Could you please replace the warning with an incremental build remark, instead of removing it?
Something like:

reporter?.report("Will not do cross-module incremental builds, wrong version of priors; expected \(expected) but read \(read) at '\(dependencyGraphPath)'")

@keith keith force-pushed the ks/remove-priors-version-mismatch-warning branch 2 times, most recently from 9e5f867 to d6ad4a8 Compare July 18, 2023 22:12
As a user when you're changing between versions of these files there's
nothing you could do to avoid invalidation so this warning feel
superfluous
@keith keith changed the title Remove priors version mismatch warning Downgrade priors version mismatch warning Jul 18, 2023
@keith
Copy link
Member Author

keith commented Jul 18, 2023

@swift-ci please test

@keith keith force-pushed the ks/remove-priors-version-mismatch-warning branch from d6ad4a8 to 855eddb Compare July 18, 2023 22:12
@keith
Copy link
Member Author

keith commented Jul 18, 2023

Updated to use that option instead! FWIW I do think that even a remark (if the user sees that) might be a bit more noise that desired (related thread: https://forums.swift.org/t/incremental-compilation-has-been-disabled-it-is-not-compatible-with-whole-module-optimization/66092). Maybe there should be a --verbose mode that implies these instead?

@keith
Copy link
Member Author

keith commented Jul 19, 2023

@swift-ci please test windows platform

@artemcm
Copy link
Contributor

artemcm commented Jul 19, 2023

Updated to use that option instead! FWIW I do think that even a remark (if the user sees that) might be a bit more noise that desired (related thread: https://forums.swift.org/t/incremental-compilation-has-been-disabled-it-is-not-compatible-with-whole-module-optimization/66092). Maybe there should be a --verbose mode that implies these instead?

The remarks are really only meant for all of us to debug what's going on with incremental builds, so I think a bit of verbosity of this kind is just fine. Still though, very good to move it away from being an actual warning.

@keith
Copy link
Member Author

keith commented Jul 19, 2023

The remarks are really only meant for all of us to debug what's going on with incremental builds, so I think a bit of verbosity of this kind is just fine. Still though, very good to move it away from being an actual warning.

Yea that makes sense, but I guess users do still end up seeing these, which might be confusing especially for ones that are this low level

@keith keith merged commit e98ddbd into swiftlang:main Jul 19, 2023
@keith keith deleted the ks/remove-priors-version-mismatch-warning branch July 19, 2023 18:15
keith added a commit that referenced this pull request Jul 19, 2023
As a user when you're changing between versions of these files there's
nothing you could do to avoid invalidation so this warning feel
superfluous

(cherry picked from commit e98ddbd / #1396)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants