Revert 'Add missing dependency (#1414)' #1481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The llbuild executable is not a dependency of this library.
artemcm
approved these changes
Nov 10, 2023
|
@swift-ci test |
|
@artemcm, this can be merged. |
|
Ping @artemcm, another CI run and this can go in. |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The llbuild executable is not a dependency of this library.
Looks like I missed removing this when I submitted the similar swiftlang/swift-llbuild#891 for llbuild itself. The issue is that this breaks cross-compiling this repo for Android armv7, because of some issue with compiling the llbuild executable, but that executable is not a real dependency in the first place.
@neonichu, please review.