Add support for swift caching with path remapping and builtin cache replay #1488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teach swift-driver to remap path when needed. This involves: * Infer SDK/toolchain related path that needs to remapped * Send path remap related arguments to swift-frontend for depscanning * Send reverse map to swift-frontend for diagnostics replay * Constructing the compilation command for main module using remapped path
Teach swift-driver to replay cached compilation result using libSwiftScan APIs directly. Jobs constructed from swift-driver is going to have a new field for all the cache keys associated with the job. The Executor can choose to query and replay using those cache keys if possible, instead of executing the build command. rdar://117947710
…ration Re-unify caching availability check behind swift feature query and adjust the default caching build configuration changes.
Remove extra `-Xcc` in the command-line.`
SwiftPM is built with `-disable-implicit-concurrency-module-import` to avoid warnings about concurrency module on older SDKs. Explicitly importing concurrency and only vend async APIs when concurrency is available.
|
Add a workaround for swift package manager if the option to disable implicit concurrency is still required. |
|
@swift-ci please test |
artemcm
approved these changes
Nov 16, 2023
And/Or from the |
|
Cross repo here: swiftlang/swift-package-manager#7125 |
|
Cross repo testing passing now. Let's try again. Feel free to revert directly if anything else break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry add swift caching support.