-
Notifications
You must be signed in to change notification settings - Fork 199
[Caching] SwiftDriver Caching API refinement for build system #1491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cachemeifyoucan
merged 4 commits into
swiftlang:main
from
cachemeifyoucan:eng/PR-swift-caching-build-system-API-refine
Dec 6, 2023
Merged
[Caching] SwiftDriver Caching API refinement for build system #1491
cachemeifyoucan
merged 4 commits into
swiftlang:main
from
cachemeifyoucan:eng/PR-swift-caching-build-system-API-refine
Dec 6, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please test |
This relies on swiftlang/swift#69934 to be functional. |
c991321
to
8d500a0
Compare
@swift-ci please test |
@swift-ci please test windows platform |
ping |
@swift-ci please test windows platform |
akyrtzi
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggested change, otherwise LGTM.
Add an API to download CASObject using CASID. This allows better task control from build system.
Expose CAS creating APIs to build system, instead of the created CAS. This allows the build system to create a different CAS if needed.
Provide a callback version of the makeGlobal API for uploading build artifacts on top of the async verison.
Exercise new CAS APIs from libSwiftScan and SwiftDriver.
8d500a0
to
1dec9d4
Compare
@swift-ci please test |
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add/adjust APIs from swift-driver for build system integration.