Skip to content

[Caching] SwiftDriver Caching API refinement for build system #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cachemeifyoucan
Copy link
Contributor

Add/adjust APIs from swift-driver for build system integration.

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@cachemeifyoucan
Copy link
Contributor Author

This relies on swiftlang/swift#69934 to be functional.

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-swift-caching-build-system-API-refine branch 2 times, most recently from c991321 to 8d500a0 Compare November 28, 2023 23:53
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test windows platform

@cachemeifyoucan
Copy link
Contributor Author

ping

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test windows platform

Copy link
Contributor

@akyrtzi akyrtzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggested change, otherwise LGTM.

Add an API to download CASObject using CASID. This allows better task
control from build system.
Expose CAS creating APIs to build system, instead of the created CAS.
This allows the build system to create a different CAS if needed.
Provide a callback version of the makeGlobal API for uploading build
artifacts on top of the async verison.
Exercise new CAS APIs from libSwiftScan and SwiftDriver.
@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-swift-caching-build-system-API-refine branch from 8d500a0 to 1dec9d4 Compare December 6, 2023 00:45
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test windows platform

@cachemeifyoucan cachemeifyoucan merged commit d6d5608 into swiftlang:main Dec 6, 2023
@cachemeifyoucan cachemeifyoucan deleted the eng/PR-swift-caching-build-system-API-refine branch December 6, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants