[Sanitizer] Add new flag -sanitize-stable-abi flag to link against the #1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new sanitiers stable ABI in compiler-rt. Compiler-rt recently introduced a stable ABI for sanitizers. This patch adds a flag to pass this flag to swift-frontend during compilation and clang at link time to link against the new stable ABI. rdar://118997873
usama54321
requested review from
tshortli,
DougGregor,
yln,
kubamracek,
devincoughlin,
rsundahl and
wrotki
|
@swift-ci test |
artemcm
reviewed
Dec 7, 2023
| @@ -216,6 +216,7 @@ extension Driver { | |||
| try commandLine.appendLast(.sanitizeEQ, from: &parsedOptions) | |||
| try commandLine.appendLast(.sanitizeRecoverEQ, from: &parsedOptions) | |||
| try commandLine.appendLast(.sanitizeAddressUseOdrIndicator, from: &parsedOptions) | |||
| try commandLine.appendLast(.sanitizeStableAbiEQ, from: &parsedOptions) | |||
There was a problem hiding this comment.
Could we please guard this with isFrontendArgSupported(.sanitizeStableAbiEQ)?
artemcm
approved these changes
Dec 7, 2023
|
Usama won't be able to add this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new sanitiers stable ABI in compiler-rt.
Compiler-rt recently introduced a stable ABI for sanitizers. This patch adds a flag to pass this flag to swift-frontend during compilation and clang at link time to link against the new stable ABI.
rdar://118997873