Skip to content

Add m68k to Triple.swift #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Add m68k to Triple.swift #1514

merged 2 commits into from
Jan 2, 2024

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Dec 27, 2023

This architecture is available in LLVM's Triple implementation and has an experimental LLVM backend available in upstream LLVM sources. It would be great to have this triple variation supported in the driver, as this architecture is relatively popular in retrocomputing enthusiast circles. It was used in Amiga, Atari ST, Sega Genesis, and of course Apple Lisa and Apple Macintosh. It is supported by Qemu and multiple Linux distributions, including Debian.

This architecture is available in [LLVM's `Triple` implementation](https://github.com/llvm/llvm-project/blob/a01b58aef0e42fb1b52e358adf4c56678a884d37/llvm/include/llvm/TargetParser/Triple.h#L62C55-L63C51) and has [an experimental LLVM backend] available in upstream LLVM sources. It would be great to have this supported, as this architecture is relatively popular in retrocomputing enthusiast circles. It was used in Amiga, Atari ST, Sega Genesis, and of course Apple Lisa and Apple Macintosh.
@MaxDesiatov MaxDesiatov added the NFC No Functional Change label Dec 27, 2023
@MaxDesiatov MaxDesiatov self-assigned this Dec 27, 2023
Copy link
Member

@rauhul rauhul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! There's a list of triples in a test file somewhere and it would be good to add a 68k triple to that list to prevent regressions.

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov merged commit c90fedf into main Jan 2, 2024
@MaxDesiatov MaxDesiatov deleted the maxd/m68k-triple branch January 2, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NFC No Functional Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants