Only run testSanitizeStableAbi on Apple platforms #1524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci Please test Windows platform |
artemcm
reviewed
Jan 17, 2024
There was a problem hiding this comment.
Could we please conditionally skip the test instead of avoiding compiling it, like this:
https://github.com/apple/swift-driver/blob/3a7016a66db3e095a439e72b9a8b63a6c3677673/Tests/SwiftDriverTests/SwiftDriverTests.swift#L7118
testSanitizeStableAbi fails on Linux. The SanitizeStableAbi for now only makes sense on Apple OSes, so limiting the test to those rdar://121121682
Yes, updated |
|
@swift-ci test |
|
@swift-ci Please test Windows platform |
artemcm
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testSanitizeStableAbi fails on Linux. The SanitizeStableAbi for now only makes sense
on Apple OSes, so limiting the test to those
rdar://121121682