Skip to content

Avoid ascii/utf encoding errors on some systems #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2024
Merged

Avoid ascii/utf encoding errors on some systems #1555

merged 1 commit into from
Mar 6, 2024

Conversation

kastiglione
Copy link
Contributor

@kastiglione kastiglione commented Mar 5, 2024 •
edited
Loading

An alternative attempt to #1554. Some systems still use Python 3.6 where reconfigure is not available.

rdar://123809082

@kastiglione kastiglione requested review from tshortli and artemcm March 5, 2024 23:24
@kastiglione
Copy link
Contributor Author

@swift-ci test

tshortli
tshortli approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@tshortli tshortli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kastiglione kastiglione merged commit 22b351b into main Mar 6, 2024
@kastiglione kastiglione deleted the python36-fix branch March 6, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

@tshortli tshortli tshortli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kastiglione @artemcm @tshortli