Skip to content

Always apply working-directory in the swift-driver #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cachemeifyoucan
Copy link
Contributor

Consistently apply working-directory even if the option is not explicitly passed. This ensures the created swift-frontend invocations can be executed anywhere without worrying about what the current directory is.

Consistently apply working-directory even if the option is not
explicitly passed. This ensures the created swift-frontend invocations
can be executed anywhere without worrying about what the current
directory is.
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test windows platform

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test windows platform

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test windows platform

1 similar comment
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test windows platform

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is reasonable.

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test windows platform

@cachemeifyoucan cachemeifyoucan merged commit f7c5749 into swiftlang:main Mar 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants