Skip to content

[Explicit Module Builds] Specify which Clang module dependencies are bridging header dependencies #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Mar 28, 2024

When passing in '-explicit-swift-module-map-file', specify which Clang modules are dependencies of textual headers of the main module and binary Swift module dependencies. This relies on a new entry-point in 'libSwiftScan': 'swiftscan_swift_binary_detail_get_header_dependency_module_dependencies'. The compiler will then use this information to determine which Clang modules require an explicit '-fmodule-map-file' ClangImporter input.

Companion to the compiler's: swiftlang/swift#72668

@artemcm
Copy link
Contributor Author

artemcm commented Mar 28, 2024

@swift-ci test

…bridging header dependencies

When passing in '-explicit-swift-module-map-file', specify which Clang modules are dependencies of textual headers of the main module and binary Swift module dependencies.
This relies on a new entry-point in 'libSwiftScan': 'swiftscan_swift_binary_detail_get_header_dependency_module_dependencies'.
The compiler will then use this information to determine which Clang modules require an explicit '-fmodule-map-file' ClangImporter input.
@artemcm artemcm force-pushed the BridgingHeaderDepModuleMapsOnly branch from 382ad05 to 5d351a7 Compare March 29, 2024 18:26
@artemcm
Copy link
Contributor Author

artemcm commented Mar 29, 2024

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Mar 29, 2024

@swift-ci test Windows platform

@artemcm artemcm merged commit ad8a328 into swiftlang:main Apr 1, 2024
3 checks passed
@artemcm artemcm deleted the BridgingHeaderDepModuleMapsOnly branch April 1, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants