Skip to content

[6.0][Caching] Remove the error for creating multiple CAS at same location #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2024
Merged

[6.0][Caching] Remove the error for creating multiple CAS at same location #1587

merged 1 commit into from
Apr 26, 2024

Conversation

cachemeifyoucan
Copy link
Contributor

  • Explanation: Remove a check in the DependencyScanningOracle that prevents creating multiple CAS at the same on disk path location. This was to prevent a race condition from multiple CAS instance that has been since fixed. On the other hand, we want to allow build system to create compatible CAS at the same path (like one connected to remote but one doesn't).
    Scope: Fixes an issue when pluginCAS is ued.
    Original PR: [Caching] Remove the error for creating multiple CAS at same location #1586
    Risk: Low. Removing error diagnostics.
    Testing: Unit tests.
    Reviewer: @akyrtzi

@cachemeifyoucan
[Caching] Remove the error for creating multiple CAS at same location
b384ae5 
Remove the CASError that prevents creating two different CAS at the same
CAS path. This allows build system to create compatible CAS at the same
location even the configuration is slightly different.
@cachemeifyoucan cachemeifyoucan requested a review from a team April 25, 2024 23:16
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@akyrtzi akyrtzi merged commit 9861561 into swiftlang:release/6.0 Apr 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cachemeifyoucan @nkcsgexi @akyrtzi