Skip to content

Prefer toolchain's plugins to SDK plugins if the toolchain has stdlib #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 1, 2024

For example, when using a swift.org toolchain, which contains the stdlib in the resource directory, we should use toolchain's SwiftMacros plugin instead of the platform's one.

@rintaro
Copy link
Member Author

rintaro commented May 1, 2024

@swift-ci Please test

@rintaro rintaro changed the title [build-script-helper] Prefer just-built plugins to SDK plugins Prefer toolchain's plugins to SDK plugins if the toolchain has stdlib May 1, 2024
For example, when using a OSS toolchain, which contains the stdlib in
the resource directory, we should use toolchain's SwiftMacros plugin
instead of the platform's one.
@rintaro rintaro force-pushed the toolchain-plugin branch from 556196e to 64cc0be Compare May 1, 2024 20:38
@rintaro
Copy link
Member Author

rintaro commented May 1, 2024

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented May 1, 2024

@swift-ci Please test Windows

Copy link

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Rintaro! Looks good.

@rintaro rintaro merged commit f2cbb46 into swiftlang:main May 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants