Revert "Work around lld 13+ issue with --gc-sections for ELF by adding -z nostart-stop-gc" #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g -z nostart-stop-gc" This reverts c771555, now that it was properly fixed in swiftlang/swift#72061.
|
@rauhul, please run the CI. |
|
@swift-ci Please test |
|
A linux toolchain build would really ensure this is okay. |
|
@kateinoigakukun, would you run a linux toolchain build with this pull, on the main compiler repo if it's not supported here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts c771555, now that it was properly fixed in swiftlang/swift#72061.
@al45tair, another follow-up to your compiler pull.